Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Fewer unsafe hacks for AppendVec#3801

Merged
aeyakovenko merged 9 commits intosolana-labs:masterfrom
aeyakovenko:fixing_storage_account
Apr 16, 2019
Merged

Fewer unsafe hacks for AppendVec#3801
aeyakovenko merged 9 commits intosolana-labs:masterfrom
aeyakovenko:fixing_storage_account

Conversation

@aeyakovenko
Copy link
Copy Markdown
Member

@aeyakovenko aeyakovenko commented Apr 16, 2019

Problem

Account structure contains an embedded Vec which makes it hard to store in memory.

Summary of Changes

  • AppendVec stores the Account in several structures which are flat. In memory pointer fixups are no longer required.
  • Allow the compiler to track lifetimes.

Fixes #

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2019

Codecov Report

Merging #3801 into master will increase coverage by <.1%.
The diff coverage is 95%.

@@           Coverage Diff            @@
##           master   #3801     +/-   ##
========================================
+ Coverage      79%     79%   +<.1%     
========================================
  Files         155     155             
  Lines       25269   25299     +30     
========================================
+ Hits        19982   20011     +29     
- Misses       5287    5288      +1

@aeyakovenko aeyakovenko merged commit 0ff2bfd into solana-labs:master Apr 16, 2019
danpaul000 pushed a commit to danpaul000/solana that referenced this pull request Apr 17, 2019
* storage account changes

* cleanup

* checks

* comments

* clippy

* tests

* woot!

* comments

* benches
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants